Updated llvm link#9
Open
princessalicorn wants to merge 2 commits intotpimh:dockerfrom
princessalicorn:docker
Open
Updated llvm link#9princessalicorn wants to merge 2 commits intotpimh:dockerfrom princessalicorn:docker
princessalicorn wants to merge 2 commits intotpimh:dockerfrom
princessalicorn:docker
Conversation
Owner
|
Does it work properly with LLVM monorepo? I think the cloning approach should be changed. |
Author
|
I am not sure, where is that at? All ik is that current one causes an LLVM clone failure |
Owner
|
I believe it would fail to clone the repo after constructing a non-existing url here. This change needs to be tested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is knda important so this script can be used, this seems to be the proper link for the llvm git repo now.